tiararodney/py-utils
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge branch 'bugfix/13' into dev

Browse source 
ID: 13
Type: bugfix
Title: fix unit tests for urllib PkgHandler
Status: done
Priority: high
Created: 2025-06-21
Description: change of issue 12 wasn't properly reflected in urllib PkgHandler
             unit tests
This commit is contained in:
Tiara Rodney 2025-06-21 20:25:43 +02:00
commit b6a24de08c
No known key found for this signature in database
GPG key ID: 5F43FAB4FBE5B5EB
2 changed files with 21 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

2
TODO
View file

@ -189,7 +189,7 @@ Description: Only bootstrap a package mock with the minimum requirements for a
ID: 13
Type: bugfix
Title: fix unit tests for urllib PkgHandler
Status: in-progress
Status: done
Priority: high
Created: 2025-06-21
Description: change of issue 12 wasn't properly reflected in urllib PkgHandler

37
tests/unit/byteb4rb1e/utils/urllib/test_request.py
View file

@ -5,7 +5,7 @@ import urllib.request
import pytest
from byteb4rb1e.testing.pytest.decorators import run_in_subprocess_once
from byteb4rb1e.testing.pytest.fixtures import mock_pkg
from byteb4rb1e.testing.pytest.fixtures import mock_system_site_package_dir
from byteb4rb1e.utils.urllib.request import PkgHandler
@ -13,7 +13,7 @@ class TestPkgHandler:
"""
"""
@run_in_subprocess_once()
def test_text(self, mock_pkg):
def test_text(self, mock_system_site_package_dir):
"""
"""
_opener: urllib.request.OpenerDirector = urllib.request.build_opener(
@ -22,9 +22,8 @@ class TestPkgHandler:
dummy_data = 'Hello'
mock_pkg('foobarpkg', {
'data.txt': dummy_data
})
pkg_dir = mock_system_site_package_dir('foobarpkg')
(pkg_dir / 'data.txt').write_text(dummy_data)
result = _opener.open('pkg://foobarpkg/data.txt').readline()
@ -33,7 +32,7 @@ class TestPkgHandler:
@run_in_subprocess_once()
def test_bytes(self, mock_pkg):
def test_bytes(self, mock_system_site_package_dir):
"""
"""
_opener: urllib.request.OpenerDirector = urllib.request.build_opener(
@ -42,9 +41,8 @@ class TestPkgHandler:
dummy_data = b'foobar123'
mock_pkg('foobarpkg', {
'data.bin': dummy_data
})
pkg_dir = mock_system_site_package_dir('foobarpkg')
(pkg_dir / 'data.bin').write_bytes(dummy_data)
result = _opener.open('pkg://foobarpkg/data.bin').readline()
@ -53,7 +51,7 @@ class TestPkgHandler:
@run_in_subprocess_once()
def test_subdir(self, mock_pkg):
def test_subdir(self, mock_system_site_package_dir):
"""
"""
_opener: urllib.request.OpenerDirector = urllib.request.build_opener(
@ -62,9 +60,12 @@ class TestPkgHandler:
dummy_data = 'foobar123'
mock_pkg('foobarpkg', {
'foo/bar/data.txt': dummy_data
})
pkg_dir = mock_system_site_package_dir('foobarpkg')
dummy_file = (pkg_dir / 'foo' / 'bar' / 'data.txt')
dummy_file.parent.mkdir(parents=True)
dummy_file.write_text(dummy_data)
result = _opener.open('pkg://foobarpkg/foo/bar/data.txt').readline()
@ -72,7 +73,7 @@ class TestPkgHandler:
@run_in_subprocess_once()
def test_nested_module(self, mock_pkg):
def test_nested_module(self, mock_system_site_package_dir):
"""
"""
_opener: urllib.request.OpenerDirector = urllib.request.build_opener(
@ -81,9 +82,11 @@ class TestPkgHandler:
dummy_data = 'foobar123'
mock_pkg('foo.bar.pkg', {
'dummy/data.txt': dummy_data
})
pkg_dir = mock_system_site_package_dir('foo.bar.pkg')
dummy_file = (pkg_dir / 'dummy' / 'data.txt')
dummy_file.parent.mkdir(parents=True)
dummy_file.write_text(dummy_data)
result = _opener.open('pkg://foo.bar.pkg/dummy/data.txt').readline()